Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alerting] encode rule/connector ids in http requests made from alerting UI #97854

Merged
merged 6 commits into from
Apr 23, 2021
Merged

[alerting] encode rule/connector ids in http requests made from alerting UI #97854

merged 6 commits into from
Apr 23, 2021

Commits on Apr 21, 2021

  1. [alerting] encode rule/connector ids in http requests made from alert… 

    …ing UI

resolves: elastic#97852

Adds `encodeURIComponent()` wrappers around references to rule, alert, and
connector ids.  Without this fix, if an alert id (which can contain
customer-generated data) contains a character that needs to be URL
encoded, the resulting API call from the web UI will fail.
    @pmuellr
    pmuellr committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    e860ded View commit details
    Browse the repository at this point in the history

  2. add jest tests

    @pmuellr
    pmuellr committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    71f30e2 View commit details
    Browse the repository at this point in the history

  3. add function test

    @pmuellr
    pmuellr committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    59b7be8 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Merge branch 'master' into alerting/encodeURIComponent

    @kibanamachine
    kibanamachine committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    3414957 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Merge branch 'master' into alerting/encodeURIComponent

    @kibanamachine
    kibanamachine committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    aa4b480 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into alerting/encodeURIComponent

    @kibanamachine
    kibanamachine committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    87403fe View commit details
    Browse the repository at this point in the history