Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated docs for 6.8 #983

Merged
merged 2 commits into from
Jan 26, 2021
Merged

updated docs for 6.8 #983

merged 2 commits into from
Jan 26, 2021

Conversation

logstashmachine
Copy link
Contributor

No description provided.

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
3cb86e3

Please, read and sign the above mentioned agreement if you want to contribute to this project

@karenzone karenzone self-requested a review January 26, 2021 17:31
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contains regressions we don't want

@@ -410,7 +410,7 @@ The sincedb record now has a last active timestamp associated with it.
If no changes are detected in a tracked file in the last N days its sincedb
tracking record expires and will not be persisted.
This option helps protect against the inode recycling problem.
Filebeat has a {filebeat-ref}/faq.html#inode-reuse-issue[FAQ about inode recycling].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Filebeat FAQ rework wasn't backported to 6.8, and the "updated" link won't work.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regressions resolved. Builds cleanly and LGTM

@karenzone karenzone merged commit 1f30731 into 6.8 Jan 26, 2021
@karenzone karenzone deleted the update_docs_1611681501 branch January 26, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants