Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups - gofmt & removing unused items #288

Closed
wants to merge 9 commits into from

Conversation

mipearson
Copy link
Contributor

  • Use a consistent gofmt setting on all files, correcting mix of tabs on logstash-forwarder / config and spaces everywhere else
  • Remove files only used during LSF's very early prototyping phase
  • go vet to remove unreachable code and fix a broken Errorf

Fixes issues I found confusing when originally trying to contribute to this project.

Visit https://github.com/elasticsearch/logstash-forwarder/pull/288/files?w=1 to see non-whitespace changes.

Subsequent rebases can be performed using --ignore-whitespace and then running gofmt or goimports on the result, because this isn't Python.

@mipearson
Copy link
Contributor Author

Hi @jordansissel - looking for some feedback on this. Am happy to rebase and rework if you'd like to only integrate some of the cleanups (eg, drop gofmt).

Also happy to rebase commits so as to keep you as origin author for git blame purposes :)

@jordansissel
Copy link
Contributor

@mipearson sorry I never seemed to make time for this one :(

Thanks for helping make logstash-forwarder better!

Logstash-forwarder is going away and is replaced by https://github.com/elastic/filebeat/. If this is still an issue with filebeat, would you mind opening a ticket there?

@mipearson
Copy link
Contributor Author

All good mate :)

On Tue, Nov 17, 2015 at 10:58 AM, Jordan Sissel notifications@github.com
wrote:

Closed #288 #288.


Reply to this email directly or view it on GitHub
#288 (comment).

Michael Pearson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants