Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to makefile to package an RPM that uses a conf.d config #527

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wfindley
Copy link

There seemed to be no good reason for new installations of logstash forwarder to use a straight config file. This PR has the Makefile drop the example config in a conf.d dir and tells pleaserun to use that instead for an arg.

@wfindley
Copy link
Author

I just signed the CLA.

@jordansissel
Copy link
Contributor

I'm not against the change, but wonder about how this will break people who
upgrade.

On Friday, September 18, 2015, wfindley notifications@github.com wrote:

There seemed to be no good reason for new installations of logstash
forwarder to use a straight config file. This PR has the Makefile drop the
example config in a conf.d dir and tells pleaserun to use that instead for

an arg.

You can view, comment on, or merge this pull request online at:

#527
Commit Summary

  • changes to makefile to package an RPM that uses a conf.d dir rather
    than a single config file.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#527.

@wfindley
Copy link
Author

Yeah, I thought about that. Conditional migration of the existing config
or just advice to migrate config file?
On Sep 18, 2015 4:59 PM, "Jordan Sissel" notifications@github.com wrote:

I'm not against the change, but wonder about how this will break people who
upgrade.

On Friday, September 18, 2015, wfindley notifications@github.com wrote:

There seemed to be no good reason for new installations of logstash
forwarder to use a straight config file. This PR has the Makefile drop
the
example config in a conf.d dir and tells pleaserun to use that instead
for

an arg.

You can view, comment on, or merge this pull request online at:

#527
Commit Summary

  • changes to makefile to package an RPM that uses a conf.d dir rather
    than a single config file.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#527.


Reply to this email directly or view it on GitHub
#527 (comment)
.

@wfindley
Copy link
Author

maybe something like this in after-install.sh?

/sbin/chkconfig --add logstash-forwarder

chown -R logstash-forwarder:logstash-forwarder /opt/logstash-forwarder
chown logstash-forwarder /var/log/logstash-forwarder
chown logstash-forwarder:logstash-forwarder /var/lib/logstash-forwarder
if [ -f /etc/logstash-forwarder.conf ]; then
  read -p "Found /etc/logstash-forwarder.conf.  Would you like to move it into /etc/logstash-forwarder.conf.d? " -n 1 -r
  echo    # move to a new line
  if [[ $REPLY =~ ^[Yy]$ ]]
  then
    mv /etc/logstash-forwarder.conf /etc/logstash-forwarder.conf.d
  fi
fi
echo "Logs for logstash-forwarder will be in /var/log/logstash-forwarder/"

@wfindley
Copy link
Author

Ok, I've tried the CLA again.

@andrewkroh
Copy link
Member

Filebeat supports the usage of a conf.d directory. It is not enabled by default but there is an open issue for this: elastic/beats-packer#27. To use a conf.d directory with Filebeat you must set the config_dir option in your config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants