-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating Node Protocol #4433
Comments
The plan is to discourage/deprecate node protocol in 2.2 and remove support for it in 3.0, the next major version. |
I think this is a good idea. But we need to be aware that some users choose node so that they have visibility into LS metrics via Marvel, so we'd need to make sure we have metrics APIs to replace this. |
Understood, though this was never an intended effect. I hope we don't upset too many folks by removing node for this purpose. Metrics in Logstash will come soon. |
+1 on discouraging/deprecating node protocol in 2.2 and removing support in the next major. |
While the http protocol is now our official stance and I agree with the push of it, there are two items that make me hesitant about doing an action such as a plan to remove all together the
|
The node protocol is a giant pain for both Logstash users and Logstash developers.
Why node is bad for users:
Users think they can use it to gain a speed boost (which it doesn't actually provide). After trying node they then wind up posting bug reports due to broken configurations (setting up a valid node is more complex than HTTP or transport). This makes for disappointed users and disappointed developers.
Why node is bad for developers:
We waste time debugging node configuration errors
We currently have to maintain an extra logstash-output-elasticsearch-license plugin JUST for the use case of shield / marvel + logstash. Additionally, the error messages generated in this scenario are plain ridiculous to debug.
Why user like node
They can see which Logstashes are active via the Elasticsearch node list (the next major of Logstash will cover this with Metrics however)
perceived speed
multicast discoverability (though we now discourage this in Elasticsearch)
IMHO we should deprecate node soon, and consider removing it in the next major release. Perhaps a community member would be interested in maintaining that as a separate plugin.
The text was updated successfully, but these errors were encountered: