Native support for Java plugins (GA) #10620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
danhermann
force-pushed
the
nsjp_ga
branch
4 times, most recently
from
c24d64c
to
0c47fbd
Compare
|
@karenzone, could you review the doc updates for the GA release of Java plugins in this commit? fd425b4 |
karenzone
approved these changes
Apr 15, 2019
danhermann
force-pushed
the
nsjp_ga
branch
2 times, most recently
from
8bec2df
to
09ff4bd
Compare
yaauie
reviewed
May 1, 2019
There was a problem hiding this comment.
This looks fantastic.
I've left a few comments in-line. My primary concerns are:
- upgrade pain for those using the Beta API already, since this does include breaking changes
- continued use of
CharsetEncoderandCharsetDecoderin our example codecs, since they are stateful and we require that implementations ofCodecbe stateless. - can users still get themselves into a tight spot with silent failures by enabling the deprecated ruby execution engine, or do we provide helpful feedback?
logstash-core/src/main/java/org/logstash/plugins/PluginFactoryExt.java
Outdated
Show resolved
Hide resolved
logstash-core/src/main/java/org/logstash/plugins/inputs/Generator.java
Outdated
Show resolved
Hide resolved
yaauie
approved these changes
May 2, 2019
| private String id; | ||
| private long threads; | ||
| private volatile boolean stopRequested = false; | ||
| private CountDownLatch countDownLatch; |
… adds float config type * Breaking change to codec.encode method * Sink output for discarding events * URI and password config types * Utility methods for packaging Java plugins * Plugin API validation, fix gemspec generation * Plugin Jar validation * Update developer documentation * Update codec metrics for new encode method * Beta: Isolated classloaders for Java plugins * Address code review comments
elasticsearch-bot
pushed a commit
that referenced
this pull request
May 3, 2019
… adds float config type * Breaking change to codec.encode method * Sink output for discarding events * URI and password config types * Utility methods for packaging Java plugins * Plugin API validation, fix gemspec generation * Plugin Jar validation * Update developer documentation * Update codec metrics for new encode method * Beta: Isolated classloaders for Java plugins * Address code review comments Fixes #10620
|
Thanks again for the review, @yaauie! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Java plugins for GA include:
codec.encode()method was changed to make the codec API easier to use correctly in pipelines with multiple concurrent workers.pipeline.plugin_classloadersflag, each Java plugin will be loaded with its own parent-last classloader. All dependencies for the Java plugin, with the exception of any classes inorg.logstash.*orco.elastic.logstash.*packages, will be loaded first from the plugin's jar file delegating to the main Logstash classloader only if the dependency is not found within the plugin's jar. This allows Java plugins to use dependencies that might clash with the dependencies for other Java plugins or Logstash core itself.gemtask will bootstrap all JRuby dependencies, automatically generateGemfileand thegemspecfile for the plugin as well as the two "glue" Ruby source files for triggering the loading of the Java class files during Logstash startup, and then invoke the necessary commands to create the gem file itself. Thegemtask also performs a number of validation checks to proactively identify common problems with the packaging of Java plugins. Thecleantask will remove all of those generated artifacts.epsoption to generate events at a given event-per-second rate for situations where as-fast-as-possible event generation is too much.jdotscodec that mirrors the Rubydotscodec.sinkoutput that discards any events received. Analogous to the Rubynullplugin though much faster.