Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workers and batch_size to root request #10853

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Add workers and batch_size to root request #10853

merged 2 commits into from
Jun 25, 2019

Conversation

cachedout
Copy link
Contributor

Adds request made by @ycombinator here.

Adds the following fields to GET /:

"pipeline" : {
  "batch_size" : 125,
  "workers" : 8
}

ycombinator
ycombinator approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally LGTM. Over to @elastic/logstash team for code review. Thanks!

@ycombinator ycombinator mentioned this pull request Jun 22, 2019
Merged
jsvd
jsvd approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comment about adding batch.delay. feel free to add and merge, I tested the current patch and LGTM

@cachedout cachedout merged commit 03001fa into elastic:master Jun 25, 2019
cachedout added a commit to cachedout/logstash that referenced this pull request Jun 26, 2019
@cachedout
Add workers and batch_size to root request (elastic#10853)
8ab7c23 
* Add workers and batch_size to root request

* Add batch delay per review recommendation
cachedout added a commit that referenced this pull request Jun 26, 2019
@cachedout
Add workers and batch_size to root request (#10853) (#10910)
20fc465 
* Add workers and batch_size to root request

* Add batch delay per review recommendation
@cachedout cachedout mentioned this pull request Jul 17, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd approved these changes

@ycombinator ycombinator ycombinator approved these changes

@yaauie yaauie Awaiting requested review from yaauie

Assignees
No one assigned
Labels
monitoring v7.3.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cachedout @jsvd @ycombinator