LOGSTASH-691: move amqp plugin to be an external plugin #338
Conversation
Depricated due to conflicts with puppet naming convention. Replaced by 'queue' variable. See LOGSTASH-755
| # other amqp broker will not work with this plugin. I do not know why. If you | ||
| # need support for brokers other than rabbitmq, please file bugs here: | ||
| # <https://github.com/ruby-amqp/bunny> </b> | ||
| # Pull events from a RabbitMQ exchange. |
There was a problem hiding this comment.
If you have a recommended version, can you specify it? Many distros ship with ancient versions of rabbitmq that probably don't work anymore with the bunny gem.
There was a problem hiding this comment.
Updated the input/output plugins with version info for Bunny & RabbitMQ, and also added version requirements to the gemspec for Bunny 0.8.x. Let me know if any more information would help.
|
Going to try and reach out to some existing logstash amqp users to help review this since I've forgotten everything about amqp. |
This has been tested with Bunny 0.8.x, which supports RabbitMQ 2.x and 3.x.
|
|
||
| # Your amqp broker's custom arguments. For mirrored queues in RabbitMQ: [ "x-ha-policy", "all" ] | ||
| # Custom arguments. For mirrored queues in rabbitmq: [ "x-ha-policy", "all" ] |
There was a problem hiding this comment.
With RabbitMQ 3x, we do not need any more to user x-ha-policy when declaring then queue.
Mirroring is done by policy, so the customs arguments are not needed for HA.
See http://www.rabbitmq.com/blog/2012/11/19/breaking-things-with-rabbitmq-3-0/
There was a problem hiding this comment.
Is the custom arguments variable no longer needed (and should be removed), or should just the doc example with policy be removed?
There was a problem hiding this comment.
This assumes rabbitmq 3. Ubuntu 12.04 still ships RabbitMQ 2.7, so I expect there to continue to be ubuntu users on 2.x at least another 2 years and debian for another 4-6 years.
There was a problem hiding this comment.
This is a good point.
So it could be good to have both configuration extract for RabbitMQ 2x and
3x.
| @@ -36,7 +36,7 @@ Gem::Specification.new do |gem| | |||
| gem.add_runtime_dependency "aws-sdk" | |||
| gem.add_runtime_dependency "heroku" | |||
| gem.add_runtime_dependency "addressable", ["~> 2.2.6"] | |||
| gem.add_runtime_dependency "bunny" | |||
| gem.add_runtime_dependency "bunny", ["~> 0.8.0"] | |||
There was a problem hiding this comment.
Since logstash release are quite frequent, we should watch the release of the stable 0.9 version of bunny.
There was a problem hiding this comment.
Bumped bunny to latest version here: 4867a89.
More information about the latest version of bunny can be found here: https://github.com/ruby-amqp/bunny#changes-in-bunny-09
frame_max is the maximum permissible size of a frame (in bytes) to negotiate with clients.
Until we have a way to know which version of rabbitmq the use has, we should let them choose whether to use the arguments variable or not.
|
@mzaccari - do you feel this is ready for merge? |
|
Gonna merge. Post-merge tasks:
|
LOGSTASH-691: move amqp plugin to be an external plugin
This renames the amqp input/output plugins to rabbitmq, with updates to documentation and references for the elasticsearch-river & zenoss plugins.