Revert to use only a single worker by default on outputs #4904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -469,7 +469,7 @@ def plugin(plugin_type, name, *args) | |||
| end | |||
|
|
|||
| def default_output_workers | |||
| @settings[:pipeline_workers] || @settings[:default_pipeline_workers] | |||
| 1 | |||
There was a problem hiding this comment.
Can we make this a constant?
The move to auto-scale output workers was great in theory, but a lot of outputs just weren't built to support it well, they often used too many resources or had logical errors.
andrewvc
force-pushed
the
revert_to_one_worker_per_output_default
branch
from
46b495c
to
2248aae
Compare
|
LGTM |
| @@ -37,6 +37,8 @@ module LogStash; class Pipeline | |||
| :config_str, | |||
| :original_settings | |||
|
|
|||
| DEFAULT_OUTPUT_WORKERS = 1 | |||
|
|
|||
| DEFAULT_SETTINGS = { | |||
There was a problem hiding this comment.
any reason not to place DEFAULT_OUTPUT_WORKERS in the DEFAULT_SETTINGS hash?
There was a problem hiding this comment.
I'd rather not have defaults in there in general. I think we should probably pull default_pipeline_workers out of there IMHO.
There was a problem hiding this comment.
Just to clarify, I think its confusing that we have dynamic settings and defaults in that hash. Defaults make more sense as constants IMHO.
|
LGTM™ too. |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Mar 28, 2016
The move to auto-scale output workers was great in theory, but a lot of outputs just weren't built to support it well, they often used too many resources or had logical errors. Fixes #4904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The move to auto-scale output workers was great in theory, but a lot of outputs
just weren't built to support it well, they often used too many resources or had
logical errors.