Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide sensitive AST/config data unless --debug-config argument passed #5025

Closed
wants to merge 1 commit into from

Conversation

purbon
Copy link
Contributor

@purbon purbon commented Apr 5, 2016

From former PR #5000,

We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

test are passing properly for this one, when testing this please make sure to use the local code base and not the released gem as there is no snapshot currently available for this branch that contains the code.

Fixes #4964

@purbon
Copy link
Contributor Author

purbon commented Apr 5, 2016

please jenkins, test this.

@purbon purbon assigned ph Apr 5, 2016
@ph
Copy link
Contributor

ph commented Apr 6, 2016

@purbon I will be closing this one since #5000 got merged in.

@ph ph closed this Apr 6, 2016
@purbon purbon deleted the fix/backport_config_hide branch May 10, 2016 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants