Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug mode can leak sensitive variables to log file via generated code #4964

Closed
andrewvc opened this issue Apr 1, 2016 · 0 comments
Closed

Debug mode can leak sensitive variables to log file via generated code #4964

andrewvc opened this issue Apr 1, 2016 · 0 comments
Assignees
@andrewvc
Labels
blocker bug v2.2.4 v2.3.1

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Apr 1, 2016

When run in debug mode logstash will print out its full pipeline ruby source which includes all arguments to filters, including password fields, in plaintext.
@andrewvc andrewvc self-assigned this Apr 1, 2016
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 1, 2016
@andrewvc
Hide generated ruby code unless --debug-config argument passed
042b85d 
We now hide this because displaying it is dangerous. Generated code
may contain plaintext copies of 'password' type fields. Users can
force this to appear with the --debug-config flag.

Fixes elastic#4964
@andrewvc andrewvc mentioned this issue Apr 1, 2016
Closed
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 1, 2016
@andrewvc
Hide generated ruby code unless --debug-config argument passed
744ed22 
We now hide this because displaying it is dangerous. Generated code
may contain plaintext copies of 'password' type fields. Users can
force this to appear with the --debug-config flag.

Fixes elastic#4964
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 1, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
3c33aa2 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 1, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
d4897b3 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 1, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
b2b74bb 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 1, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
1c0a190 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 1, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
a63968d 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 1, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
b2e9638 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 1, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
a6bdfec 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 3, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
f3e3a9b 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 3, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
5b26efe 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 3, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
eb2a878 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
@andrewvc andrewvc mentioned this issue Apr 3, 2016
Closed
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 4, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
8354ec2 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
elasticsearch-bot pushed a commit that referenced this issue Apr 4, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
7afcef6 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes #4964

Fixes #4965
elasticsearch-bot pushed a commit that referenced this issue Apr 4, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
7748630 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes #4964

Fixes #4987
elasticsearch-bot pushed a commit that referenced this issue Apr 4, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
1b27429 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes #4964

Fixes #4987
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 4, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
131c48f 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
@andrewvc andrewvc mentioned this issue Apr 4, 2016
Merged
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 4, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
5ca14ff 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 5, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
9bbf74e 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
andrewvc added a commit to andrewvc/logstash that referenced this issue Apr 5, 2016
@andrewvc
Hide sensitive AST/config data unless --debug-config argument passed
f11e20f 
We now hide this because displaying it is dangerous. Generated code
and other AST data may contain plaintext copies of 'password' type fields.
Users can force this to appear with the --debug-config flag.

Fixes elastic#4964
@purbon purbon mentioned this issue Apr 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewvc andrewvc

Labels
blocker bug v2.2.4 v2.3.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewvc