Event#toMap should return copy #5296
Conversation
|
I think we need to verify current usages of |
|
ah, I forgot about this one that I changed in the previous PR. will update |
|
@colinsurprenant thanks, updated. I see no other usages |
| @@ -4,6 +4,9 @@ | |||
|
|
|||
| import java.io.IOException; | |||
| import java.util.*; | |||
|
|
|||
| import static org.hamcrest.CoreMatchers.not; | |||
| import static org.hamcrest.core.IsSame.sameInstance; | |||
There was a problem hiding this comment.
are we introducing a new org.hamcrest dependency?
There was a problem hiding this comment.
looks like it has already been included. I just autocompleted. unless I am mistaken?
There was a problem hiding this comment.
I liked the sameInstance assertion from there, so I started typing it. and it worked. so I stuck with it
|
Looks like it is somehow shadowed inside the |
|
I don't really mind if we introduce a new testCompile dep but I am not sure how this can work if it is not included in |
|
It is being brought in by |
|
well. it doesn't matter anymore. I removed the code dependency |
|
LGTM |
No description provided.