[WiP] Enhanced config validation mechanism for logstash plugins #5779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add new structure call config::mixinnextgen to map new layout for the config mixin * add default code to handle class and proc validators * add the option to pass the params object to the validators to they can actually do cross validation * add the concept of BlockValidator used to wrap anything that respond to call
|
@andrewvc @jordansissel @guyboertje you might like to take a look here, this is actually the first sketch with happy tests all over from the idea I just shared with you. @jsvd this is the PR we spoke about this morning, looking forward to see how the setting and this coercions could be DRY'ed. |
|
seems this WiP is no longer relevant. should be restarted with a clean slate if anyone feels otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been created as work in progress example to have initial revision.
There are a lot of things that can, could and for sure will change in this PR, opened this as discussed with @jordansissel and @jsvd to have a tool to discuss.
TODO (pending):
Test:
Current test pas at core level and also locally I updated the file and jdbc inputs and the date filter with passing tests, as this touches and important component of LS, more detailed test will be pulled to be sure there no missing bit pending.
Notes to reviewers
Please focus on:
Think will be a living creature to don't think of this as something final, we might not even merge it 馃樃.
For more details check #5778