#6828 Use json-schema in tests

[original-brownbear]

one step for #6828 :)

@ph this is what you had in mind right? (didn't do all specs yet in case the answer is "no" :))

[ph]

Yes, but I am wondering if we could have some helper to write the schema?

[original-brownbear]

@ph def, we should dry this up before merging imo. Let me fix the other cases real quick then and see what I can do about that :)

[original-brownbear]

@ph added the remaining cases that I could at reasonable effort port. Two cases, namely:

  context "#values" do

    let(:payload) { LogStash::Json.load(last_response.body) }

    it "return totals of plugins" do
      expect(payload["total"]).to eq(payload["plugins"].count)
    end

    it "return a list of available plugins" do
      payload["plugins"].each do |plugin|
        expect do 
          Gem::Specification.find_by_name(plugin["name"])
        end.not_to raise_error
      end
    end

seem very hard to port since the schema validation has no comparison logic across fields.
I am starting to have some doubts about drying this up though. I think we should be careful here, in a sense we're substituting our own "DSL" for the schema doing that.
When looking at the concrete things we could dry up this seems like it might be more trouble than it's worth in terms of readability?

[original-brownbear]

@ph can you give this another look whenever you find a sec? :)

[ph]

LGTM, much cleaner.

[elasticsearch-bot]

Armin Braun merged this into the following branches!

Branch	Commits
master	153eea6, a10a7eb