Filter invocation improvements #7902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original-brownbear
force-pushed
the
filter-invocation-improvements
branch
from
d9104ca
to
2309a51
Compare
original-brownbear
force-pushed
the
filter-invocation-improvements
branch
from
2309a51
to
03af1e7
Compare
|
I agree. Nice find. |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Aug 4, 2017
elasticsearch-bot
pushed a commit
that referenced
this pull request
Aug 4, 2017
elasticsearch-bot
pushed a commit
that referenced
this pull request
Aug 4, 2017
Closed
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are doing quite a few operations on the
RubyEventthat benefit from a proper hashcode and equals method.The ones we get from
RubyObjectaren't very efficient for our purposes (since theRubyEventholds no state, all we care about is reference equality anyway).equalsto only check reference equalityhashCodereturnfrom the hot loop (no effect really, but I came across using explicit return with external reference from define_method is 66x slower on 9k jruby/jruby#3715 the other day :D)Overall this seems to speed up larger batches slightly.