Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file names to list of LS config files #9321

Closed
wants to merge 1 commit into from

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Apr 3, 2018

Added pipelines.yml and log4j2.properties to list of Logstash config files:
https://www.elastic.co/guide/en/logstash/master/config-setting-files.html

Summary of changes:

@karenzone karenzone added the docs label Apr 3, 2018
@karenzone karenzone changed the title Add pipelines.yml to list of LS config files Add pipelines.yml and log4j2.properties to list of LS config files Apr 4, 2018
@karenzone karenzone changed the title Add pipelines.yml and log4j2.properties to list of LS config files Add file names to list of LS config files Apr 4, 2018
Add anchor to log4j2 topic heading for linking
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Otherwise content changes LGTM.

Starting with 5.0, you can configure logging for a particular subsystem in Logstash. For example, if you are
debugging issues with Elasticsearch Output, you can increase log levels just for that component. This way
When debugging problems, particularly problems with plugins, it can be helpful to increase the logging level to `DEBUG`
to get more verbose messages. Previously, you could only set a log level that applied to the entire Logstash product.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we're 3 minors into the 6.x release, I wonder if it's still relevant to mention that this feature was added in 5.0? It might still be helpful for support to have this info, but it also makes the content seem a bit dated. Might be worth initiating a conversation on the techpubs channel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent point and good discussion in techpubs channel. I added "Decide on best approach for version references in docs. Clean up accordingly." to my LS documentation meta issue so I won't forget it.

@karenzone
Copy link
Contributor Author

I did some crazy stuff with word wrap and squashing commits. Think I cleaned all that up.
The net result should be:

*`jvm.options`*::
Contains JVM configuration flags. Specify each flag on a separate line. You can also use this file to set the locale
for Logstash.
Contains JVM configuration flags. Use this file to set initial and maximum values for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for adding this!

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearch-bot
Copy link

karen.metts merged this into the following branches!

Branch Commits
master 06f697d
6.x 9ccecfb
6.1 abcdc07
6.2 7bbdbf1

elasticsearch-bot pushed a commit that referenced this pull request Apr 9, 2018
…nchor to log4j2 topic heading for linking

Fixes #9321
elasticsearch-bot pushed a commit that referenced this pull request Apr 9, 2018
…nchor to log4j2 topic heading for linking

Fixes #9321
elasticsearch-bot pushed a commit that referenced this pull request Apr 9, 2018
…nchor to log4j2 topic heading for linking

Fixes #9321
@dedemorton dedemorton mentioned this pull request Apr 17, 2018
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants