Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLEANUP: Dry up filter wrapper setup #9337

Conversation

original-brownbear
Copy link
Member

Minor, but makes porting java_filter_delegator.rb to Java a lot easier (crucial step for the Java plugin API branch that can go into master already), just factored this part out of the port for easier review.

  • Set up filter class in plugin factory outside of delegators instead of in the delegator constructor -> drier and easier to read
  • Adjusted tests accordingly

Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Member Author

@danhermann thanks :)

@elasticsearch-bot
Copy link

Armin Braun merged this into the following branches!

Branch Commits
master 7cea457
6.x ab78c0b

elasticsearch-bot pushed a commit that referenced this pull request Apr 8, 2018
@original-brownbear original-brownbear deleted the dry-up-plugin-factory branch April 8, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants