-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a track for date_histogram #113
Conversation
Adds a track to nyc taxis to test `date_histogram` performance.
This creates test data for elastic/elasticsearch#55559 |
I pushed an update fixing some names, fixing some target intervals, and adding |
^^Sorry I didn't see the update, I will rerun with new target intervals. From latency vs service time it looks like target-interval/throughout for
|
^^Sorry I didn't see the changes to target intervals, I will rerun with new target intervals. |
Correct! I hear tell that we don't really have room in the nightlies. I'll be doing a fair bit of work on agg performance in the next few weeks and mostly plan to run them myself because of the lack of room.
That depends on the version of Elasticsearch you are using! If you have master as of this weekend then the service times should be much more similar between tz and not-tz. ~30% or ~40% different. |
I re-run with the latest elasticsearch and the latest update. Latency and service time look reasonable. Thank you!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Thanks for reviewing @ebadyano ! |
Adds a track to nyc taxis to test `date_histogram` and `auto_date_histogram` performance.
Adds a track to nyc taxis to test `date_histogram` and `auto_date_histogram` performance.
Adds a track to nyc taxis to test `date_histogram` and `auto_date_histogram` performance.
Adds a track to nyc taxis to test
date_histogram
performance.