Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trailing slashes for all URL schemes #1119

Conversation

danielmitterdorfer
Copy link
Member

With this commit we extend the leniency added in #1111 to all URL
schemes (including s3 and gs).

Relates #1111
Relates #1110

With this commit we extend the leniency added in elastic#1111 to all URL
schemes (including `s3` and `gs`).

Relates elastic#1111
Relates elastic#1110
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Track Management New operations, changes in the track format, track download changes and the like labels Nov 20, 2020
@danielmitterdorfer danielmitterdorfer added this to the 2.0.3 milestone Nov 20, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Nov 20, 2020
@danielmitterdorfer
Copy link
Member Author

Note to reviewers: See the Python documentation for supported URL schemes.

Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmitterdorfer
Copy link
Member Author

One integration test has failed with:

2020-11-20 08:04:18,567 ActorAddr-(T|:33891)/PID:23047 esrally.actor ERROR Worker [5] has exited prematurely. Aborting benchmark.

The logs don't provide any further indication why the actor has exited but in any case this looks unrelated so I'll retrigger a build.

@elasticmachine test this please

@danielmitterdorfer danielmitterdorfer merged commit 2a6c62a into elastic:master Nov 20, 2020
@danielmitterdorfer danielmitterdorfer deleted the trailing-slash-all-schemes branch November 20, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants