Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow trailing / in base-url #1111

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Allow trailing / in base-url #1111

merged 1 commit into from
Nov 17, 2020

Conversation

dliappis
Copy link
Contributor

Closes #1110

@dliappis dliappis added bug Something's wrong :Track Management New operations, changes in the track format, track download changes and the like labels Nov 16, 2020
@dliappis dliappis added this to the 2.0.3 milestone Nov 16, 2020
@dliappis dliappis self-assigned this Nov 16, 2020
danielmitterdorfer
danielmitterdorfer approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dliappis dliappis merged commit 3e3158a into elastic:master Nov 17, 2020
@dliappis dliappis deleted the trailing_bash_url_slashes branch November 17, 2020 10:15
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this pull request Nov 20, 2020
@danielmitterdorfer
Support trailing slashes for all URL schemes
614367f 
With this commit we extend the leniency added in elastic#1111 to all URL
schemes (including `s3` and `gs`).

Relates elastic#1111
Relates elastic#1110
@danielmitterdorfer danielmitterdorfer mentioned this pull request Nov 20, 2020
Merged
danielmitterdorfer added a commit that referenced this pull request Nov 20, 2020
@danielmitterdorfer
Support trailing slashes for all URL schemes (#1119)
2a6c62a 
With this commit we extend the leniency added in #1111 to all URL
schemes (including `s3` and `gs`).

Relates #1111
Relates #1110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

Assignees

@dliappis dliappis

Labels
bug Something's wrong :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.

base-url property in corpora doesn't accept trailing / for https
2 participants
@dliappis @danielmitterdorfer