Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix num of docs in -1k generated corpus #1318

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Conversation

dliappis
Copy link
Contributor

Fix number of docs in -1k file generated by the create-track
subcommand.

Closes #1317

Fix number of docs in -1k file generated by the create-track
subcommand.

Closes elastic#1317
@dliappis dliappis added bug Something's wrong :Usability Makes Rally easier to use labels Aug 31, 2021
@dliappis dliappis added this to the 2.3.0 milestone Aug 31, 2021
@dliappis dliappis requested a review from DJRickyB August 31, 2021 14:01
@dliappis dliappis self-assigned this Aug 31, 2021
Copy link
Contributor

@DJRickyB DJRickyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Took me a bit to follow what was happening in the it but I see now, nice

@dliappis dliappis merged commit db06c98 into elastic:master Sep 1, 2021
@dliappis
Copy link
Contributor Author

dliappis commented Sep 1, 2021

@DJRickyB thank you for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong :Usability Makes Rally easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong amount of docs for test corpora when creating a track with create-track
2 participants