Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically bake in subfolder installs into npm install #353

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Automatically bake in subfolder installs into npm install #353

merged 3 commits into from
Jul 17, 2019

Conversation

cee-chen
Copy link
Member

Description

I kept messing up dependency installs (documented here) and thought I'd make it more idiot-proof for future me 😄

Now instead of having to run 3 separate install commands, just running the default npm install/yarn install commands will also trigger installing packages/package.json and lerna bootstrap.

List of changes

  • Add a postinstall script that auto-installs subfolder dependencies
  • Update CircleCI
  • Update docs

@cee-chen cee-chen changed the title Automatically bake in subfolder installs into root install command Automatically bake in subfolder installs into npm install Jul 17, 2019
Copy link
Member

@JasonStoltz JasonStoltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @constancecchen!

@cee-chen
Copy link
Member Author

Phew, looks like CircleCI does indeed run postinstall after npm ci (was a little worried about that) - merging! 🎉

@cee-chen cee-chen merged commit 5ae6f21 into elastic:master Jul 17, 2019
@cee-chen cee-chen deleted the npm-install branch July 17, 2019 20:58
@yakhinvadim
Copy link
Contributor

I really like postinstall usage here 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants