Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read Kibana version from /api/stats instead of /api/settings #572

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Read Kibana version from /api/stats instead of /api/settings #572

merged 3 commits into from
Feb 11, 2022

Conversation

antbell
Copy link
Contributor

@antbell antbell commented Feb 10, 2022

Description

Fixes #571

@antbell antbell marked this pull request as ready for review February 10, 2022 22:14
@antbell antbell requested a review from a team as a code owner February 10, 2022 22:14
@antbell antbell changed the title Read Kibana version from /api/stats or /api/settings Read Kibana version from /api/stats instead of /api/settings Feb 11, 2022
pickypg
pickypg approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@pickypg pickypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for tackling this @antbell!

@pickypg pickypg merged commit 4ec74d4 into elastic:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickypg pickypg pickypg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix version detection for Kibana 8.0
2 participants
@antbell @pickypg