Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --rich-metadata flag to enable all rich metrics #289

Closed
andrewvc opened this issue May 25, 2021 · 1 comment · Fixed by #294
Closed

Add --rich-metadata flag to enable all rich metrics #289

andrewvc opened this issue May 25, 2021 · 1 comment · Fixed by #294
Labels
enhancement New feature or request refined Issue refined, ready to work on

Comments

@andrewvc
Copy link
Contributor

andrewvc commented May 25, 2021

We currently have a number of flags that are used by heartbeat in conjunction with the – – json output, such as --screenshots and --network. As we add new flags we are creating a compatibility issue between heartbeat and the synthetics agent. Newer versions of heartbeat must add additional flags to gain from their functionality, thus breaking compatibility with older suites using older versions of the synthetics agent which do not support that flag.

This issue proposes adding a new meta-tag --rich-metrics that can stably be used by heartbeat which turns on the relevant flags in the synthetics agent. An additional benefit here is that adding new flags to the synthetics agent won't require adding them to the beats code base.

@andrewvc andrewvc added enhancement New feature or request [zube]: Ready refined Issue refined, ready to work on labels May 25, 2021
@andrewvc andrewvc changed the title Add --rich-metrics flag to enable all rich metrics Add --rich-metadata flag to enable all rich metrics May 25, 2021
@vigneshshanmugam
Copy link
Member

++ to this approach, We need to investigate a bit on our CLI param and options on how we can make use of commander for these grouping. I feel like --rich-events makes more sense as we already discussed screenshot does not belong much in metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refined Issue refined, ready to work on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants