New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: capture performance metrics from trace events #194
feat: capture performance metrics from trace events #194
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
14cbc0f
to
b5e6a82
Compare
598baa4
to
b5921e5
Compare
b5921e5
to
14fd134
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a partial review here will follow up with a complete review ASAP
FYI I did reach out to @drewpost and discuss the fact that metrics we collect are not aligned up with lighthouse or many other tools due to the fact that specific browser versions and platform differences will prevent numbers from lining up exactly. Once this is merged we should be sure sure to document these differences and explain performance in the synthetics documentation. I've opened elastic/observability-docs#735 to track |
@andrewvc Thanks Andrew for taking care of that and the info. |
14fd134
to
525d6c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM however I'll leave it up to you to determine whether you want to move the fields out of the payload now or in a subsequent PR. We can't build GUI features based on this until we have proper elasticsearch fields defined in our mappings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
trace
flag withfilmstrips
in the CLI.journey/metrics
to reflect the trace output timing information.Notice.txt
which ppints to Lighthouse license as we are using their trace processor for extracting key metrics.Trace output is in this format
start, end - Timings that are relative to step/journey start and end times.