Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prioritize suite params over config #298

Merged
merged 1 commit into from Jun 3, 2021
Merged

fix: prioritize suite params over config #298

merged 1 commit into from Jun 3, 2021

Conversation

vigneshshanmugam
Copy link
Member

  • fix Config files break --suite-params #297
  • We now deep merge the params passed from both config and suite params and always prioritize suite params over config params when a key is specified in both.

@apmmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #298 opened

  • Start Time: 2021-06-03T19:49:22.331+0000

  • Duration: 13 min 52 sec

  • Commit: c23867f

Test stats 🧪

Test Results
Failed 0
Passed 103
Skipped 0
Total 103

Trends 🧪

Image of Build Times

Image of Tests

andrewvc
andrewvc approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigneshshanmugam vigneshshanmugam merged commit 4dd37d5 into elastic:master Jun 3, 2021
@vigneshshanmugam vigneshshanmugam deleted the merge-params branch June 3, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config files break --suite-params
3 participants
@vigneshshanmugam @apmmachine @andrewvc