New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete entire project via push command #598
feat: delete entire project via push command #598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really need a --yes
flag here I think
write(''); | ||
// Makes testing easier with overrides | ||
let deleteAll = false; | ||
if (process.env.TEST_OVERRIDE != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add a --yes
flag to skip this in case someone wants to automate it for any reasons.
I did try running with yes | npx @elastic/synthetics push
but our command really dislikes that and tries to process all the input thus stalling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will address this separately and open a PR. #601
Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm OK with --yes
coming in a future PR
Yes
would nuke the entire project in Kibana.