Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete entire project via push command #598

Merged
merged 2 commits into from Sep 19, 2022

Conversation

vigneshshanmugam
Copy link
Member

  • fix add support to delete the entire project with push #581
  • users would be promoted with a dialog when pushing with empty monitors which then clicking Yes would nuke the entire project in Kibana.
  • Also fixed a bug where we kept pushing even on auth errors, now we immediately exit when we find errors during pushing.

@apmmachine
Copy link
Collaborator

apmmachine commented Sep 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-19T16:53:49.330+0000

  • Duration: 14 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 187
Skipped 2
Total 189

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

src/push/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need a --yes flag here I think

write('');
// Makes testing easier with overrides
let deleteAll = false;
if (process.env.TEST_OVERRIDE != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a --yes flag to skip this in case someone wants to automate it for any reasons.

I did try running with yes | npx @elastic/synthetics push but our command really dislikes that and tries to process all the input thus stalling.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will address this separately and open a PR. #601

Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm OK with --yes coming in a future PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support to delete the entire project with push
3 participants