Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore yml files inside node_modules dir #714

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

vigneshshanmugam
Copy link
Member

@apmmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-09T20:45:40.300+0000

  • Duration: 15 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 213
Skipped 2
Total 215

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested by duplicating my existing heartbeat.yml file in node_modules for the project. Was able to recreate the issue and confirm it's fixed by this PR.

@vigneshshanmugam vigneshshanmugam merged commit 081e914 into elastic:main Mar 10, 2023
@vigneshshanmugam vigneshshanmugam deleted the fix-712 branch March 10, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validation with node_modules monitor examples
3 participants