Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation with node_modules monitor examples #712

Closed
shahzad31 opened this issue Mar 6, 2023 · 2 comments · Fixed by #714
Closed

validation with node_modules monitor examples #712

shahzad31 opened this issue Mar 6, 2023 · 2 comments · Fixed by #714
Labels
bug Something isn't working

Comments

@shahzad31
Copy link
Contributor

image
@shahzad31 shahzad31 added the bug Something isn't working label Mar 6, 2023
@vigneshshanmugam
Copy link
Member

I am not sure if this a bug. Seems like you linked the agent from your local folder and it kinda takes everything from there. We can add an option to ignore node_modules, but I don't see users running in to this problem.

@vigneshshanmugam vigneshshanmugam mentioned this issue Mar 9, 2023
Merged
@vigneshshanmugam
Copy link
Member

Seems like we always had this issue, but since our templating logic was broken cbf4c4e we never picked it up. Addressing that one, revealed the other bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ignore yml files inside node_modules dir vigneshshanmugam/synthetics
2 participants
@shahzad31 @vigneshshanmugam