New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: capture non error type in json reporter #856

Merged

vigneshshanmugam merged 1 commit into elastic:main from vigneshshanmugam:fix-non-error

Oct 24, 2023

Member

vigneshshanmugam commented Oct 23, 2023

Throwing non-error type in the steps results in weird String split error as we were trying to split on error.message which is not the correct thing to do. This was already handled in the Base reporter.
PR address the same by capturing the throwed primitive values/objects from the Journey/Steps and capturing them as error.message which Kibana uses to visualize the error when running inside Heartbeat.

step('Test', async () => {
  throw 'error';
});


          fix: capture non error type in json reporter

48caa88

vigneshshanmugam requested review from emilioalvap, andrewvc and devcorpio

October 23, 2023 17:45

emilioalvap approved these changes

View reviewed changes

Contributor

emilioalvap left a comment

LGTM

vigneshshanmugam merged commit cb4c8fb into elastic:main

9 checks passed

vigneshshanmugam deleted the fix-non-error branch

October 24, 2023 15:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment