Add versioning and 7.x support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couldn't we just have the 7.0 version in non ndjson and use it for all of 7.x. I assume Kibana will do the conversion until the end of 7.x automatically to not have a breaking change. Like this we don't need any special folder structure. |
|
@ruflin that's fine. The only caveat is our users will see a warning about the format of the file, but it should still load. |
andrewvc
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ndjsonversion of our dashboard, which will be relevant for7.1+, and moves the original version to a6.xdirectory.The
ndjsonversion will not upload correctly in Kibana7.0.0, so we will need to reflect that in the folder structure. The existing dashboard imports fine to7.0.*, so we don't need to merge this until7.1is released.