Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate lifecycle management of a trainingJob #16

Merged
merged 1 commit into from
Mar 20, 2018
Merged

migrate lifecycle management of a trainingJob #16

merged 1 commit into from
Mar 20, 2018

Conversation

qizheng09
Copy link
Contributor

This pr comes from #634, contains the main process of lifecycle of a TrainingJob. Including:

  1. creating resources;
  2. maintaining a state machine;
  3. releasing resources；

@qizheng09 qizheng09 force-pushed the migrate_lifecycle_management branch from e36ce87 to fe7e119 Compare March 19, 2018 03:25
typhoonzero
typhoonzero approved these changes Mar 20, 2018
View reviewed changes
Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@typhoonzero typhoonzero merged commit 7b540c1 into elasticdeeplearning:develop_CRD Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

@Yancey1989 Yancey1989 Awaiting requested review from Yancey1989

@helinwang helinwang Awaiting requested review from helinwang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qizheng09 @typhoonzero