Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making functions for get_password() and set_password() #141

Closed
ljm42 opened this issue Jul 8, 2022 · 1 comment
Closed

Consider making functions for get_password() and set_password() #141

ljm42 opened this issue Jul 8, 2022 · 1 comment

Comments

@ljm42
Copy link
Contributor

ljm42 commented Jul 8, 2022

I would like to move the transcrypt password out of the git config file and come up with some other method of storing it.

I'm wondering if you'd be open to creating functions for get_password() and set_password(), something like this:

get_password() {
  local password=$(git config --get --local transcrypt.password)
  echo "$password"
}

set_password() {
  local password=$1
  git config transcrypt.password "$password"
}

the code would call those like this:

  current_password=$(get_password)
  set_password "$password"

Then in my implementation I would just have to modify those functions and not all the places that get/set the password. Would you be open to that?

Oh, with these names the current get_password() would have to be renamed, maybe get_password_from_user() ?

jmurty pushed a commit that referenced this issue Jul 10, 2022
Read and write password with new `load_password()` and `save_password()` functions.
This makes it easier for others to override password handling with minimal changes.
@jmurty
Copy link
Collaborator

jmurty commented Jul 10, 2022

Solved with new load_password() and save_password() functions merged from #142, thanks for the improvement!

@jmurty jmurty closed this as completed Jul 10, 2022
jmurty added a commit that referenced this issue Oct 15, 2022
# By James Murty (18) and others
# Via GitHub (1) and James Murty (1)
* main: (26 commits)
  Centralise load and save of password into functions #141
  Fix date of 2.2.0 release
  Ensure tests use "main" as default branch name #143
  Use OpenSSL for B64 encoding not `base64` which differs between Linux and Mac #140
  Use core attributesFile from worktree (#137)
  Document `xxd` requirement, and make optional with OpenSSL < 3 (#138)
  Prepare for 2.2.0 release
  Fix when using OpenSSL 3 which no longer embeds salt in output (#135)
  Consolidate all git operation scripts into a single transcrypt script
  Fix handling of small files and files with null in first 8 bytes (#116)
  Improve command hint to fix secret files not encrypted in index (#120) (#130)
  Remove Ubuntu 16.04 LTS from test matrix (#123)
  Configure default Git branch name for macOS tests in GitHub
  Handle rename of primary branch from "master" to "main"
  Ensure Git index is up-to-date before dirty repo  check #37 (#109)
  Fix incorrect salt when partially staged files are commited (#119)
  Use shorthand for grep options for broader compatibility (#121)
  Let user set a custom path to openssl #108
  Install entire transcrypt script into repository
  Change version to indicate development "pre-release" status
  ...

# Conflicts:
#	README.md
#	tests/_test_helper.bash
#	tests/test_cleanup.bats
#	tests/test_crypt.bats
#	tests/test_init.bats
#	tests/test_not_inited.bats
#	transcrypt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants