Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create functions for get_password() and set_password() #142

Merged
merged 3 commits into from
Jul 10, 2022

Conversation

ljm42
Copy link
Contributor

@ljm42 ljm42 commented Jul 9, 2022

This makes it easier to override password handling locally
See #141

This makes it easier to override password handling locally
@jmurty
Copy link
Collaborator

jmurty commented Jul 9, 2022

Hi @ljm42 I like this change thanks, but I think it could be even clearer if the new functions could be called load_password() and save_password() instead of using the get/set prefixes. This would also remove the need to rename the existing get_password() function to get_password_from_user()

What do you think?

@ljm42
Copy link
Contributor Author

ljm42 commented Jul 9, 2022

Great idea! Can you squash these to a single commit? Or I could create a new PR on a clean branch if you'd like?

@jmurty
Copy link
Collaborator

jmurty commented Jul 9, 2022

It’s fine to make changes on this branch. I’ll squash at merge time

@ljm42
Copy link
Contributor Author

ljm42 commented Jul 10, 2022

Perfect. This should be good unless you see other issues

@jmurty jmurty merged commit 93f9d4c into elasticdog:main Jul 10, 2022
@ljm42 ljm42 deleted the feat-custom-password branch July 11, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants