New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

精简POM依赖 #268

Closed

jearton opened this issue Apr 10, 2017 · 1 comment

Labels

jearton commented Apr 10, 2017 •

edited

Loading

lombok不应该是compile依赖，应该加上<scope>provided</scope>
curator-test、junit、unitils-core、mockito-core、h2，这几个依赖是不是应该加上<scope>test</scope>

这些依赖如果不指定scope，就传递到使用者的项目里了，这是不合理的。我不可能把lombok、junit之类的打包到最终可执行的jar里去的（比如springboot应用）

terrymanu added the enhancement label

Member

haocao commented Apr 10, 2017

1.lombok应该改为compile依赖。
2.junit、unitils-core、mockito-core、h2已经是test的scope，curator-test应该改为test的scope。
下个版本会更新。

haocao changed the title ~~com.dangdang:elastic-job-common-core:2.0.5的pom依赖有问题~~ 精简POM依赖

haocao closed this as completed in

f645f25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment