Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "size": 0 for Term Facet #1776

Closed
ctrochalakis opened this issue Mar 9, 2012 · 31 comments
Closed

Support "size": 0 for Term Facet #1776

ctrochalakis opened this issue Mar 9, 2012 · 31 comments

Comments

@ctrochalakis
Copy link

Is it possible to add support for setting "size": 0 to simple Term Facets in order to return all terms matching the hits?

This should be similar to the TermsStats Facet api.

@kimchy
Copy link
Member

kimchy commented Mar 9, 2012

Yes, its definitely possible. I plan to do some refactoring in this area, once its done, we can then add this.

@ctrochalakis
Copy link
Author

Great, keep up the good work :)

@daetal-us
Copy link

Excellent.

Just wanted to give a big thumb up (two, even!) to this idea.

also, when implemented this might also close #1530

@TLoD-Snake
Copy link

+1 vote for this feature!

@jzelez
Copy link

jzelez commented Apr 12, 2012

+1

@edwardsmit
Copy link

+1 vote for this feature

@michaelirey
Copy link

Loving elasticsearch... I would really benefit from this feature. Any update on the status of this issue?

@ghost
Copy link

ghost commented Sep 5, 2012

Haven't had a chance to look at the issue, but past experience with earlier lucene and ESP, would suggest you are asking for a 0 to represent a null entry? Is that really what is meant?

On Sep 5, 2012, at 2:06 PM, Michael Irey wrote:

Loving elasticsearch... I would really benefit from this feature. Any update on the status of this issue?


Reply to this email directly or view it on GitHub.

@michaelirey
Copy link

Really just looking for a way to ask for all facets to be returned... Perhaps omitting the the size param or having it set to all. Right now I have it set to a really high number. See: http://stackoverflow.com/questions/12285371/elasticsearch-number-of-facets-returned

@MrJohnsson77
Copy link

+1

@jperelli
Copy link

jperelli commented Oct 2, 2012

Why is this issue open and documentation says: "The size parameter controls how many facet entries will be returned. It defaults to 10. Setting it to 0 will return all terms matching the hits"?
http://www.elasticsearch.org/guide/reference/api/search/facets/terms-stats-facet.html
What is the truly behavior?

@tikitu
Copy link

tikitu commented Oct 9, 2012

@jperelli the docs you're looking at are for the terms stats facet, not the terms facet: in the terms facet setting size to 0 just gives you no terms back.

@jperelli
Copy link

jperelli commented Oct 9, 2012

You are right, in a closer look, I confused this issue with that part of the docs. Sorry!

@gjb83
Copy link

gjb83 commented Dec 20, 2012

+1

1 similar comment
@pvulgaris
Copy link

+1

@kimchy
Copy link
Member

kimchy commented Jan 4, 2013

Fellows, just an update, its high on our prio list!, we are going to go through the mentioned refactoring and implement it. Its simpler now with Lucene 4 upgrade effectively done.

@ZogStriP
Copy link

👍

1 similar comment
@tfreitas
Copy link

+1

@pjrt
Copy link

pjrt commented Mar 3, 2013

+!

@fmardini
Copy link

+1

@pjrt
Copy link

pjrt commented Mar 15, 2013

Isn't this already implemented with the "all_terms" option?

@tikitu
Copy link

tikitu commented Mar 20, 2013

@pjrt: Nope. The "all_terms" option says "also include in the list terms that appear somewhere in the index for this field but that have no hits in this query" (i.e., entries with a count of zero). But the "size" parameter says "how many items from the top of the list should I actually return?"

On 15 mrt. 2013, at 18:16, Pedro Rodriguez notifications@github.com wrote:

Isn't this already implemented with the "all_terms" option?


Reply to this email directly or view it on GitHub.

@nickstreet
Copy link

+1 👍

@trenpixster
Copy link

+1

1 similar comment
@quentin389
Copy link

+1

@joafeldmann
Copy link

Since there is a "size" field, is it possible to also have a "from" field to paginate through facets?

@taijinlee
Copy link

+1

2 similar comments
@JohanTan
Copy link

JohanTan commented Nov 8, 2013

+1

@mbedna
Copy link

mbedna commented Nov 19, 2013

+1

@bobrik
Copy link
Contributor

bobrik commented Dec 2, 2013

Any updates? @kimchy said about priority list 11 months ago :)

I noticed weird thing today: all_terms with terms_stats returns all terms, but with terms facet you should specify size explicitly.

I guess this is not going to happen, aggregations are coming.

@dweiss
Copy link
Contributor

dweiss commented Jan 21, 2014

+1 to this. I don't think all_terms works as advertised at http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/search-facets-terms-facet.html

@jpountz
Copy link
Contributor

jpountz commented Jan 22, 2014

This feature has been implemented on aggregations (#4837). I am closing this issue as we are not going to modify facets anymore in order to focus on aggregations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests