-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reroute API response didn't filter metadata #7523
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the reroute API should return the new cluster state, excluding the metadata. It was however it was wrongly using an old parameter (filter_metadata) and thus failed to do so. This commits restores but wiring it to the correct `metric` parameter. Closes elastic#7520
can we add constants to the metrics, so such a problem won't happen again? |
clintongormley
changed the title
[Rest] reroute API response didn't filter metadata
REST: Reroute API response didn't filter metadata
Sep 8, 2014
bleskes
force-pushed
the
reroute_filter_metadata
branch
from
September 10, 2014 12:23
d6c3040
to
54f419c
Compare
LGTM |
bleskes
added a commit
that referenced
this pull request
Sep 10, 2014
By default the reroute API should return the new cluster state, excluding the metadata. It was however it was wrongly using an old parameter (filter_metadata) and thus failed to do so. This commits restores but wiring it to the correct `metric` parameter. We also add an enum representing the possible metrics, to avoid similar future mistakes. Closes #7520 Closes #7523
karmi
added a commit
to elastic/elasticsearch-ruby
that referenced
this pull request
Sep 15, 2014
clintongormley
changed the title
REST: Reroute API response didn't filter metadata
Reroute API response didn't filter metadata
Jun 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the reroute API should return the new cluster state, excluding the metadata. It was however it was wrongly using an old parameter (filter_metadata) and thus failed to do so. This commits restores but wiring it to the correct
metric
parameter.Closes #7520
PS. The name
metric
for filtering cluster state feels wrong, but this remains for another change (and a discussion)