Extract a common base class for (Master|Nodes)FaultDetection #7512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They share a lot of settings and logic
|
LGTM |
| transportService.removeConnectionListener(connectionListener); | ||
| } | ||
|
|
||
| abstract void handleTransportDisconnect(DiscoveryNode node); |
There was a problem hiding this comment.
can we document this method?
|
left minor comments other than that LGTM |
bleskes
added a commit
that referenced
this pull request
Sep 1, 2014
They share a lot of settings and some logic. Closes #7512
|
thx simon. Pushed this into improve_zen. |
bleskes
added a commit
to bleskes/elasticsearch
that referenced
this pull request
Sep 1, 2014
They share a lot of settings and some logic. Closes elastic#7512
bleskes
added a commit
that referenced
this pull request
Sep 8, 2014
They share a lot of settings and some logic. Closes #7512
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They share a lot of settings and logic
Note: this pr is against the feature/improve_zen branch and is part of the review process of #7493