Enable event processing without matching mapping #391

elbwalker · Jun 6, 2024 · 8092770 · 8092770
1 parent a6a4030
commit 8092770
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/.changeset/brown-owls-visit.md b/.changeset/brown-owls-visit.md
@@ -0,0 +1,6 @@
+---
+'@elbwalker/walker.js': major
+---
+
+Enable event processing without matching mapping
+(#391)[https://github.com/elbwalker/walkerOS/issues/391]
diff --git a/packages/clients/walkerjs/src/__tests__/destination.test.ts b/packages/clients/walkerjs/src/__tests__/destination.test.ts
@@ -209,13 +209,15 @@ describe('Destination', () => {
     const destinationB: WebDestination.Destination = {
       push: mockPushB,
       config: {
-        mapping: { '*': { action: {} } },
+        mapping: { '*': { action: {}, '*': { ignore: true } } },
       },
     };
 
     const destinationC: WebDestination.Destination = {
       push: mockPushC,
-      config: { mapping: { entity: { '*': {} } } },
+      config: {
+        mapping: { entity: { '*': {} }, '*': { '*': { ignore: true } } },
+      },
     };
 
     elb('walker destination', destinationA);
@@ -267,7 +269,7 @@ describe('Destination', () => {
 
     jest.clearAllMocks();
     elb('random action');
-    expect(mockPushA).toHaveBeenCalledTimes(0);
+    expect(mockPushA).toHaveBeenCalledTimes(1);
     expect(mockPushB).toHaveBeenCalledTimes(1);
     expect(mockPushC).toHaveBeenCalledTimes(0);
     expect(mockPushB).toHaveBeenCalledWith(
@@ -281,7 +283,7 @@ describe('Destination', () => {
 
     jest.clearAllMocks();
     elb('entity random');
-    expect(mockPushA).toHaveBeenCalledTimes(0);
+    expect(mockPushA).toHaveBeenCalledTimes(1);
     expect(mockPushB).toHaveBeenCalledTimes(0);
     expect(mockPushC).toHaveBeenCalledTimes(1);
     expect(mockPushC).toHaveBeenCalledWith(
@@ -295,7 +297,7 @@ describe('Destination', () => {
 
     jest.clearAllMocks();
     elb('absolutely unacceptable');
-    expect(mockPushA).toHaveBeenCalledTimes(0);
+    expect(mockPushA).toHaveBeenCalledTimes(1);
     expect(mockPushB).toHaveBeenCalledTimes(0);
     expect(mockPushC).toHaveBeenCalledTimes(0);
   });
@@ -665,7 +667,6 @@ describe('Destination', () => {
           '*': {
             visible: { batch: 2000 },
             click: { batch: 2000 },
-            important: {},
           },
         },
       },

diff --git a/packages/clients/walkerjs/src/lib/push.ts b/packages/clients/walkerjs/src/lib/push.ts
@@ -137,9 +137,6 @@ export function pushToDestination(
       // Check to use specific event names
       if (mappingEvent.name) event.event = mappingEvent.name;
     }
-
-    // don't push if there's no matching mapping
-    if (!mappingEvent) return false;
   }
 
   const pushed = !!tryCatch(() => {