Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement end to end tests and solve several bugs #34

Merged
merged 11 commits into from
Feb 10, 2024

Conversation

elchininet
Copy link
Owner

@elchininet elchininet commented Feb 10, 2024

This pull request implements end-to-end tests to test the plugin directly in a Home Assistant instance using Playwright. During the building of the tests, several bugs were spotted and directly solved and covered:

  • Fix js-template update using ‘states.entity’.
  • Fix js-template update using states.domain when the domain contained an underscore
  • Fix a bug about the js-template of the title not being updated if there were no items with js-templates.
  • Fix a bug that provoked that some items were not matched in some ocassions.
  • Fix a bug that were returning undefined as a string in templates with error or that return undefined.
  • Fix a bug about the icon of an existing element not being updated because of an error.

@elchininet elchininet merged commit fb84103 into master Feb 10, 2024
4 checks passed
@elchininet elchininet deleted the implement_end_to_end_tests branch February 10, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant