Handle CTRL+C and cleanup privileged sniffer pods #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichaelWasher would you mind reviewing this? |
This was referenced Jul 29, 2022
|
@bostrt will it be released? It is not in 1.6.2 as I can see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is partially addressing a few other issues:
Addresses ctrl+c portion of ksniff graceful shutdown on Ctrl+C + Wireshark doesn't close on exit #66
Handling ctrl+c and calling cleanup: Cleanup sniffers on SIGINT #131
Addresses the issue in Pods are not removed on Ctrl +C #130
Address the issue except for lingering static-tcpdump processes in How to exit and cleanup after running ksniff with -o option? #53
Cleanup of the static-tcpdump process is going to need to be handled in another PR. I believe the only way to kill that process is to send a ctrl+c via the remotecommand/SPDY connection which is tricky (source) which is the workaround until this is resolved.
I'll also submit another PR for properly closing Wireshark upon a CTRL+C along with an option like
--keep-wiresharkto keep wireshark open after closing ksniff.