Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pods are not removed on Ctrl +C #130

Closed
MichaelWasher opened this issue Sep 27, 2021 · 3 comments
Closed

Pods are not removed on Ctrl +C #130

MichaelWasher opened this issue Sep 27, 2021 · 3 comments

Comments

@MichaelWasher
Copy link
Contributor

Ksniff does not react gracefully to SIGINT / SIGTERM signals.

This can result in zombie Pods remaining when using the Privileged sniffer.
@MichaelWasher
Copy link
Contributor Author

This should do the trick but wasn't sure if we also wanted to catch the SIGTERMs incase the application is run inside Kube Pods. @bostrt Would be handy to have a discussion about where you think the signal handler should go.
#131

@MichaelWasher
Copy link
Contributor Author

/assign

@bostrt bostrt mentioned this issue Jul 15, 2022
Merged
@bostrt
Copy link
Collaborator

bostrt commented Jul 29, 2022

Addressed in #147

@bostrt bostrt closed this as completed Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bostrt @MichaelWasher