Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update & Add Support of Likert Scales #21

Merged
merged 10 commits into from
Dec 7, 2016
Merged

Update & Add Support of Likert Scales #21

merged 10 commits into from
Dec 7, 2016

Conversation

paltman
Copy link
Contributor

@paltman paltman commented Dec 6, 2016

No description provided.

@coveralls
Copy link

coveralls commented Dec 6, 2016 •
edited
Loading

Coverage Status

Coverage increased (+1.6%) to 21.958% when pulling 850b65f on overhaul into 4d700b0 on master.

@coveralls
Copy link

coveralls commented Dec 7, 2016 •
edited
Loading

Coverage Status

Coverage increased (+1.6%) to 21.958% when pulling b2e3299 on overhaul into 4d700b0 on master.

jtauber
jtauber approved these changes Dec 7, 2016
View reviewed changes
Copy link
Member

@jtauber jtauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just that stray scale

formly/forms/design.py
scale = self.cleaned_data["scale"]
if scale:
return [s.strip() for s in scale.split(",")]
scale
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this line for?

@paltman paltman merged commit 55fdf65 into master Dec 7, 2016
@paltman paltman deleted the overhaul branch December 7, 2016 19:37
@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 21.987% when pulling 4da1401 on overhaul into 4d700b0 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 21.987% when pulling 4da1401 on overhaul into 4d700b0 on master.

@coveralls
Copy link

coveralls commented Dec 7, 2016 •
edited
Loading

Coverage Status

Coverage increased (+1.6%) to 21.987% when pulling 4da1401 on overhaul into 4d700b0 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtauber jtauber jtauber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paltman @coveralls @jtauber