Invert implementations to run/stop oscillator #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRaUnite
changed the title
eldruin
reviewed
Jan 27, 2023
There was a problem hiding this comment.
Nice catch, thank you!
Could you add an entry to the changelog and also invert Bit 7 accordingly in the run/halt tests?
I see now that some methods in a dependency have become deprecated and I have to update those too for the CI to pass.
|
I fixed the problems that made the CI fail. |
- inverted CH flag in run tests - reflected changes in the changelog.
Done. I haven't noticed that I forgot about the |
|
For the record, I have released this fix in version 0.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2.