Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for queries in text #40

Closed
wants to merge 3 commits into from

Conversation

gerhardgossen
Copy link
Contributor

Implements the search in the Wiki content requested in #18.

The results are returned as instances of net.sourceforge.jwbf.core.contentRep.SearchResult. An additional contentRep class SearchResultList is used internally for deserialization from JSON.

@eldur
Copy link
Owner

eldur commented Dec 7, 2014

It is okay for you if I rebase your changes and squash your three commits to one?

@gerhardgossen
Copy link
Contributor Author

Sure, I'd have done it myself if I hadn't pushed it already.

@eldur
Copy link
Owner

eldur commented Dec 7, 2014

Your change looks good, thanks again, I tend to merge your changes. I'm going to change the following parts with further patches:

  • rename TextQuery to Search because all other queries are named by the list parameter
  • reformat to 2 space indentation 😉
  • extract json responses to textfiles like you have done with search.json

I hope it's okay that I'll merge your change after release of jwbf 3.1 (see #38).

@eldur
Copy link
Owner

eldur commented Dec 7, 2014

rebased and merged with b3fc6b1 -- greetings from Hamburg

@eldur eldur closed this Dec 7, 2014
@gerhardgossen gerhardgossen deleted the issue18 branch December 16, 2014 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants