set album input title maxlength to varchar(50) length #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References https://github.com/electerious/Lychee/issues/305 and https://github.com/electerious/Lychee/issues/325 If need, set display length by css
|
What happens when you set an album title of 50 chars including specials chars like ä, ö, ü etc.? I guess they will take more space than the allowed 50 chars of the database field. |
|
No, that works well. |
|
hmm sorry, no it does not - after a reload. The size shown will be size minus the amount of umlaut chars. |
|
I will update the database field with the next version (>3.0), so the title can contain more chars. Than we can adjust the limit in the Front-End. |
|
PR has been out-closed by GitHub because I deleted the v3.0 branch. Will take care of it. |
electerious
added a commit
that referenced
this pull request
May 10, 2015
|
A length of 50chars is now allowed (see develop branch). |
electerious
added a commit
that referenced
this pull request
May 14, 2015
- Stopped view.js from cutting album and photo titles (#332) - Fixed album sorting (getByID, deleteByID) - Fixed jQuery each bug when opening empty album - Stop showing deleted photos in photo switcher
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #305 and #325
If need, set display length by css