Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning message for abnormal vote counts #221

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Conversation

na399
Copy link
Contributor

@na399 na399 commented Mar 24, 2019

There are myriads of abnormalities in the results. This exceeding number of vote counts is one of them. I suggest that we should warn the viewer that this weird result is probably incorrect.

Screenshot 2019-03-25 at 03 23 40

@codeclimate
Copy link

codeclimate bot commented Mar 24, 2019

Code Climate has analyzed commit 3b0a073 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (0% is the threshold).

This pull request will bring the total coverage in the repository to 5.0% (-3.0% change).

View more on Code Climate.

@p16i
Copy link
Contributor

p16i commented Mar 25, 2019

I would suggest using this description:

พบความผิดพลาดในข้อมูลของกกต. รอการตรวจสอบอีกครั้ง

@na399
Copy link
Contributor Author

na399 commented Mar 25, 2019

We may go for that, as it clearly states the responsible entity for this error, which in this case is likely to be กกต. Having said that, the error might be from our side, so I think we might not be able to mention the source of the error. What do you think?

Anyway, it seems that กกต. has resolved the issue. Hopefully, we won't see this error again ... but who knows?

@p16i
Copy link
Contributor

p16i commented Mar 25, 2019

agreed, I'm going to merge anyway. Thank you very much for your contribution, although the election has already finished.

@p16i p16i merged commit cb4515a into electinth:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants