fix(client): Reintroduce global emitter #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would lean towards this revert rather than a larger change at this time. When we add multi-tab support the event miter architecture is going to change. |
|
@samwillis I think I agree since we plan on overhauling it soon then might as well keep this global - ultimately the issues arise from the fact that we use a global registry as well, the handling of multiple electrifications and disposing of resources needs a bit more care. |
kevin-dp
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1191 for description of issues that arose from removing the global emitter.
I'm opening this PR in the case we decide that we want to reintroduce it as it ensures that all instantiated electric clients will share notifications between them.