Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found bug when using storage in web worker, it always fallback to
nodefs
no matter what storage we use. turns out, when we initializePGLiteWorker
, we parsedataDir
now
dataDir
is the parsed value, for example fromidb://my-database
to only/my-database
withoutidb://
. then when we initialize the worker, we are using parsed value instead the the raw value, and this value will be parsed again inPGLite
so no mattter what storage used in web worker, it's always using
nodefs
, because we always parsing the parsed value toPGLite