Fix PDF footnotes #661
Merged
Fix PDF footnotes #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I missed this when creating EBTv2, so footnotes were broken when we started merging HTML for PDF. This fixes that, and improves the logic, too.
✅ Deploy Preview for electric-book ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
LouiseSteward
approved these changes
Apr 19, 2023
assets/js/footnotes.js
Outdated
| containingElement, footnoteReferenceContainer; | ||
| // Make a div.page-footnote | ||
| var pageFootnote = document.createElement('div') | ||
| // pageFootnote.className += ' page-footnote' |
There was a problem hiding this comment.
Perhaps remove this commented-out line before merging?
There was a problem hiding this comment.
@LouiseSteward Thanks! Nice catch. Done in 5f4f6d7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this when creating EBTv2's merged HTML, so on-page footnotes were broken in PDF output. This fixes that, improves the logic, and adds examples.